optimize and simplify

- use more fstrings
- use exceptions
- don't print "oh lol"
- drop tempfiles

1 files changed, 4 insertions, 14 deletions

diff --git a/scripts/elvia_gridtariff.py b/scripts/elvia_gridtariff.py
index 4475c48..3e8ed1e 100644
--- a/scripts/elvia_gridtariff.py
+++ b/scripts/elvia_gridtariff.py
@@ -40,30 +40,20 @@ try:
     }
 
     response = requests.post(url, headers=hdr, json=body, timeout=10)
-    if response.status_code != 200:
-        print(response.status_code)
-        print("Oh shit")
-        response.raise_for_status()
+    response.raise_for_status()
 
 except requests.exceptions.RequestException as e:
-    print("oh lol")
     sys.exit(e)
 
 data = response.json()
 
-print(
-    "Got "
-    + str(len(data["gridTariffCollections"][0]["gridTariff"]["tariffPrice"]["hours"]))
-    + " items from between "
-    + startTime
-    + " and "
-    + endTime
-)
-
+num_items = len(data["gridTariffCollections"][0]["gridTariff"]["tariffPrice"]["hours"])
+print(f"Got {num_items} items from between {startTime} and {endTime}")
 
 ### insert data into database
 
 values = []
+
 for item in data["gridTariffCollections"][0]["gridTariff"]["tariffPrice"]["hours"]:
     values.append(
         (